Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Compile fix for DISABLE_CONTEXT_SWITCHING build. #62

Merged
merged 1 commit into from Aug 21, 2012

Conversation

Projects
None yet
2 participants
Member

mavam commented Aug 21, 2012

When configured with --disable-context-switching, I could not build unstable:

/home/matthias/libcppa/src/thread_pool_scheduler.cpp:294:11: error: prototype for ‘cppa::actor_ptr cppa::detail::thread_pool_scheduler::spawn(cppa::void_function, cppa::scheduling_hint, cppa::init_callback)’ does not match any in class ‘cppa::detail::thread_pool_scheduler’
In file included from /home/matthias/libcppa/src/thread_pool_scheduler.cpp:42:0:
/home/matthias/libcppa/./cppa/detail/thread_pool_scheduler.hpp:68:15: error: candidates are: virtual cppa::actor_ptr cppa::detail::thread_pool_scheduler::spawn(cppa::void_function, cppa::init_callback, cppa::scheduling_hint)
/home/matthias/libcppa/src/thread_pool_scheduler.cpp:288:11: error:                 virtual cppa::actor_ptr cppa::detail::thread_pool_scheduler::spawn(cppa::void_function, cppa::scheduling_hint)
/home/matthias/libcppa/src/thread_pool_scheduler.cpp:247:11: error:                 virtual cppa::actor_ptr cppa::detail::thread_pool_scheduler::spawn(cppa::scheduled_actor*, cppa::init_callback, cppa::scheduling_hint)
/home/matthias/libcppa/src/thread_pool_scheduler.cpp:240:11: error:                 virtual cppa::actor_ptr cppa::detail::thread_pool_scheduler::spawn(cppa::scheduled_actor*, cppa::scheduling_hint)

The reason was a signature mismatch between a header and implementation file.

Neverlord added a commit that referenced this pull request Aug 21, 2012

Merge pull request #62 from mavam/hotfix
Compile fix for DISABLE_CONTEXT_SWITCHING build.

@Neverlord Neverlord merged commit 045941b into actor-framework:unstable Aug 21, 2012

Owner

Neverlord commented Aug 21, 2012

Thank you for the patch, but why do you need to compile with context switching disabled?

Member

mavam commented Aug 21, 2012

I think it was a left-over from earlier times where disabling context switching prevented a system freeze on 64-bit Linux. I just tried to remove the --disable-context-switching option and fortunately no issues arose.

Owner

Neverlord commented Aug 21, 2012

Ok. At least the left-over was good to find this bug. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment