-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile.alpine for alpine buil; add tini to debian image #22
Conversation
Based upon the discussion in #14 i have added tini to both dockerfiles. |
I have tested both dockerfiles locally. Final sizes are 235M for the debian based image and 102M for the alpine one. docker build -f Dockerfile.alpine . |
LGTM! Thanks! |
Awesome, thanks for coming to solution! |
Oh shoot there's a conflict. @brtwrst mind fixing? |
Yes this happened because #14 was merged. Which changes the What should i provide now?
|
I have recreated the originally proposed configuration.
|
The idea looks good to me. There is a go to image which is debian based , and for those who want alpine based there is one too. Thank you @brtwrst for the effort. |
Thanks for the work @brtwrst! I ended up reverting the other PR and then reverting that revert because I didn't see you had based your changed on it. That let me merge your changes in. Can you double-check on that docker files look correct? |
They are correct, thanks for your time |
This PR adds a separate
Dockerfile.alpine
to build an image based on Alpine Linux.The resulting image will be just over 100M in size.
The build and resulting image works on AMD64 (Tested on Ubuntu 20.04) and ARM64 (Tested on a RPI3 with Ubuntu 22.04)
During testing i switched between the
yarn start
andnode app.js
start commands and when using the latter, the container will exit with code 143 (which i think is the correct code) as opposed to exit code 1 when usingyarn start
.So i included the
node app.js
command for now.