Web port of the react native edit transaction view by Cldfire · Pull Request #1340 · actualbudget/actual

Cldfire · 2023-07-15T03:56:44Z

Relates to #604.

Original React Native experience:

RPReplay_Final1689392915.MP4

Experience ported to web in iOS PWA:

RPReplay_Final1689392569.MP4

Everything except split transaction editing is here and functional. I didn't implement split transactions because:

I don't use them personally
It's significantly more work for significantly less gain
I don't think the way it was implemented in React Native was particularly ergonomic, and it would likely benefit from a redesign before being implemented again for web
It's a logical way to keep this MR smaller than it otherwise would be

Other future improvements possible:

Customize the payee / account / category autocomplete modals more for mobile, they could benefit from more touch-friendly layouts (particularly the size of the item rows, to make them easier to tap)
Add a toggle switch component instead of the checkbox for "cleared"
Fix the mobile account view so it works when you navigate to it directly instead of first loading the accounts view and then tapping into the transaction list. Right now if you go there without having loaded the accounts view first it breaks. (I already fixed this for the edit transaction view.)
Style polish
Implement split transaction editing ([Feature] Split transactions in mobile app #1352)
Move the + symbol somewhere more centrally located so a transaction could be entered with one hand (left or right). (from @shall0pass)
Translate the class components into functional ones
Combine the serializeTransaction and deserializeTransaction functions added here for mobile with the desktop counterparts in a way that works for both
Add some automated testing

This avoids content observation behavior in WebKit on touch devices that delays the onClick event (and therefore reaction to user input).

netlify · 2023-07-15T03:56:53Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`5cfa762`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/64d16ab5b42fad000882050a
😎 Deploy Preview	https://deploy-preview-1340.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2023-07-15T03:59:41Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16 → 14	2.1 MB → 2.12 MB (+18.39 kB)	+0.86%

Changeset

File	Δ	Size
`src/components/mobile/MobileAmountInput.js`	🆕 +5.13 kB	0 B → 5.13 kB
`../../node_modules/react-redux/es/connect/selectorFactory.js`	🆕 +3.83 kB	0 B → 3.83 kB
`src/components/mobile/MobileForms.js`	🆕 +1.97 kB	0 B → 1.97 kB
`src/icons/v2/PencilWriteAlternate.js`	🆕 +914 B	0 B → 914 B
`../../node_modules/react-redux/es/utils/shallowEqual.js`	🆕 +649 B	0 B → 649 B
`src/icons/v1/Trash.js`	🆕 +383 B	0 B → 383 B
`src/components/transactions/MobileTransaction.js`	📈 +15.01 kB (+166.40%)	9.02 kB → 24.04 kB
`src/components/autocomplete/AccountAutocomplete.js`	📈 +1.77 kB (+92.65%)	1.91 kB → 3.68 kB
`src/components/autocomplete/CategorySelect.tsx`	📈 +1.87 kB (+70.84%)	2.64 kB → 4.51 kB
`src/components/autocomplete/PayeeAutocomplete.js`	📈 +1.94 kB (+29.31%)	6.63 kB → 8.57 kB
`src/components/modals/EditField.js`	📈 +488 B (+14.82%)	3.22 kB → 3.69 kB
`src/components/autocomplete/Autocomplete.tsx`	📈 +1.42 kB (+11.12%)	12.78 kB → 14.2 kB
`src/components/FinancesApp.tsx`	📈 +660 B (+8.47%)	7.61 kB → 8.25 kB
`../loot-core/src/shared/transactions.ts`	📉 -7 B (-0.13%)	5.26 kB → 5.25 kB
`src/components/accounts/MobileAccountDetails.js`	📉 -27 B (-0.82%)	3.22 kB → 3.2 kB
`src/components/accounts/MobileAccount.js`	📉 -261 B (-4.29%)	5.94 kB → 5.68 kB
`webpack/runtime/get javascript chunk filename`	📉 -34 B (-7.16%)	475 B → 441 B

View detailed bundle breakdown

Added

No assets were added

Removed

Asset	File Size	% Changed
static/js/281.chunk.js	28.55 kB → 0 B (-28.55 kB)	-100%
static/js/876.chunk.js	26.2 kB → 0 B (-26.2 kB)	-100%

Bigger

Asset	File Size	% Changed
static/js/main.js	854.72 kB → 938.68 kB (+83.96 kB)	+9.82%

Smaller

Asset	File Size	% Changed
static/js/narrow-components.chunk.js	32.2 kB → 24.62 kB (-7.58 kB)	-23.55%
static/js/wide-components.chunk.js	159.63 kB → 156.68 kB (-2.95 kB)	-1.85%
asset-manifest.json	2.07 kB → 1.78 kB (-296 B)	-13.97%

Unchanged

Asset	File Size	% Changed
static/js/171.chunk.js	396.24 kB	0%
static/media/Inter-italic.var.woff2	239.29 kB	0%
static/media/Inter-roman.var.woff2	221.86 kB	0%
static/js/383.chunk.js	117.35 kB	0%
static/js/reports.chunk.js	40.96 kB	0%
static/js/969.chunk.js	12.94 kB	0%
static/js/resize-observer-polyfill.chunk.js	8.12 kB	0%
static/css/main.css	5.82 kB	0%
index.html	1.66 kB	0%
static/media/browser-server.js	963 B	0%

github-actions · 2023-07-15T03:59:43Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	1.97 MB	0%

Changeset

File	Δ	Size
`packages/loot-core/src/shared/transactions.ts`	📉 -7 B (-0.10%)	6.85 kB → 6.84 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1012.12 kB	0%
xfo.xfo.kcab.worker.js	1004.04 kB	0%

Cldfire · 2023-07-15T04:34:52Z

I'd appreciate any tips on fixing up the tests; I tried running yarn test locally, but it hangs after loot-core:

j-f1 · 2023-07-15T15:16:29Z

This is awesome! I will take a look at the tests and do some more code review later today.

j-f1

I definitely need to spend a bunch of time reading through the larger chunks of code, but here are some initial things that jumped out at me.

trevdor · 2023-07-29T03:45:01Z

Here's how the layout squishes two different ways depending on which keyboard is open (editing date or amount):
(iPhone 13 mini)

Cldfire · 2023-07-29T03:50:55Z

Interesting! It looks like you're not using Safari which must be cause of the difference. I was aware of the layout issues but I was unable to replicate that situation on my iPhone.

I'll fix the layout this weekend so the fields can't squish together like that.

trevdor · 2023-07-29T03:54:53Z

Not getting the cryptic error I got the first time. 🤷🏻‍♂️ Never mind!
And you're right, in Safari, both regular and full-screen "Add to Home" mode I can't repro.
Thanks for looking at it -- if you come up with a fix, great, but I wouldn't consider this a blocker for such an important feature when it works in the mode folks are most likely to use it on iOS.

Cldfire · 2023-07-31T04:06:11Z

f430014 should fix the layout issues up in Firefox.

before	after

Cldfire · 2023-08-03T19:49:35Z

I just pushed e6fc12a which makes a couple small tweaks to use a type="date" input for the date field, resulting in a much-improved native date picker experience when editing transaction dates:

RPReplay_Final1691091738.mov

trevdor · 2023-08-04T17:57:46Z

Hey @Cldfire! This looks awesome. One color tweak in the nav bar (excuse my un-resized huge images):

This branch:

Before:

After that, @MatissJanis this looks good for whenever we can roll it into a release!
(Pardon my slowness...been away at a family reunion.)

MatissJanis · 2023-08-04T18:00:15Z

The footer is getting addressed here: #1456

It's a regression. :)

So feel free to ignore that piece of feedback in this PR. We just need the e2e tests to pass

trevdor

Thanks Matiss for the regression pointer.

Looks good!

MatissJanis · 2023-08-07T18:27:29Z

@Cldfire would you mind taking a look at the failing e2e test and the merge conflict? Once CI passes we're happy to merge. 🎉

Cldfire · 2023-08-07T21:48:40Z

Waiting on #1486 to merge before proceeding here.

EDIT: actually ended up just cherry-picking the commit for now.

Cldfire · 2023-08-07T22:17:21Z

@Cldfire would you mind taking a look at the failing e2e test and the merge conflict? Once CI passes we're happy to merge. 🎉

CI is green and merge conflicts are gone 😄 once #1486 merges this can then be merged.

* Set `role="button"` on downshift autocomplete items This avoids content observation behavior in WebKit on touch devices that delays the onClick event (and therefore reaction to user input). * Disable split transaction editing for now

Cldfire added 18 commits July 6, 2023 00:56

Add non-functional port of the RN edit transaction component

32e8f95

Working buttons and functional input fields

86dd5a6

Stop using location state to pass transactions to edit component

9c8cea9

Remove add transaction from toolbar

0dfd392

Start using edit field modal

000dbc4

Lots of UI improvements

2484281

Implement adding transactions from transactions list

60578a2

Stop edit field modal from closing on blur

ba9df74

Set role="button" on downshift autocomplete items

df94fa0

This avoids content observation behavior in WebKit on touch devices that delays the onClick event (and therefore reaction to user input).

userSelect: none some things

1263062

Fix amount input styling

2d5b293

Fix cleared checkbox

de9436a

Improve autocomplete styling

f28d2a6

Improve modal layout

3541eba

Fix routing when loading URLs directly

37569fd

Add button for changing sign of transaction

1df5448

Disable split transaction editing for now

e3d2205

Fix focus bug when adding transaction

12de3a0

trafico-bot Bot added the 🔍 Ready for Review label Jul 15, 2023

Cldfire added 4 commits July 14, 2023 23:59

Add changelog entry

e79bc89

Fix lint error

ab31f7a

Fix typecheck errors

5e96cc2

Merge branch 'master' into jarek/port-rn-edit-transaction

c3a7a63

j-f1 reviewed Jul 15, 2023

View reviewed changes

j-f1 requested a review from trevdor July 15, 2023 16:50

Fix layout when edit transaction view is vertically challenged

f430014

Cldfire added 2 commits July 31, 2023 00:10

Change transaction edit / new routes

3bc55d6

Merge branch 'master' into jarek/port-rn-edit-transaction

b556ae1

Cldfire requested a review from trevdor July 31, 2023 04:32

Cldfire added 4 commits July 31, 2023 00:40

Un-fix transaction table tests

9077c18

Fix bare buttons

4ab9175

Fix navigation after transaction save / delete

f92ef44

Use native date picker for transaction editing on mobile devices

e6fc12a

trevdor approved these changes Aug 5, 2023

View reviewed changes

MatissJanis added this to the v23.9.0 milestone Aug 5, 2023

Merge branch 'master' into jarek/port-rn-edit-transaction

81c511b

Cldfire added 2 commits August 7, 2023 17:51

Fix mobile account view

2c84f76

Fix build after merging master

5cfa762

trevdor merged commit e9137fc into actualbudget:master Aug 8, 2023

trafico-bot Bot added ✨ Merged and removed 🔍 Ready for Review labels Aug 8, 2023

github-actions Bot mentioned this pull request Aug 8, 2023

[Feature] Adding transactions on responsive mobile #604

Closed

1 of 2 tasks

Cldfire deleted the jarek/port-rn-edit-transaction branch August 8, 2023 03:40

Cldfire changed the title ~~Initial port of react native edit transaction view~~ Web port of the react native edit transaction view Oct 18, 2023

Conversation

Cldfire commented Jul 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Jul 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for actualbudget ready!

Uh oh!

github-actions Bot commented Jul 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats — desktop-client

Uh oh!

github-actions Bot commented Jul 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats — loot-core

Uh oh!

Cldfire commented Jul 15, 2023

Uh oh!

j-f1 commented Jul 15, 2023

Uh oh!

j-f1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trevdor commented Jul 29, 2023

Uh oh!

Cldfire commented Jul 29, 2023

Uh oh!

trevdor commented Jul 29, 2023

Uh oh!

Cldfire commented Jul 31, 2023

Uh oh!

Cldfire commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trevdor commented Aug 4, 2023

Uh oh!

MatissJanis commented Aug 4, 2023

Uh oh!

trevdor left a comment

Choose a reason for hiding this comment

Uh oh!

MatissJanis commented Aug 7, 2023

Uh oh!

Cldfire commented Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Cldfire commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Cldfire commented Jul 15, 2023 •

edited

Loading

netlify Bot commented Jul 15, 2023 •

edited

Loading

github-actions Bot commented Jul 15, 2023 •

edited

Loading

github-actions Bot commented Jul 15, 2023 •

edited

Loading

Cldfire commented Aug 3, 2023 •

edited

Loading

Cldfire commented Aug 7, 2023 •

edited

Loading