-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Aria Button on Autocomplete and Filters #2915
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
865cfd0
to
2ed42f6
Compare
f54b15d
to
6276039
Compare
2ed42f6
to
00a582b
Compare
6276039
to
34110cb
Compare
00a582b
to
230049e
Compare
34110cb
to
d9d42a5
Compare
230049e
to
9cc1778
Compare
0219011
to
b5375c7
Compare
9cc1778
to
631dfae
Compare
0b417a0
to
c2a2650
Compare
631dfae
to
1ee4a16
Compare
c2a2650
to
7d8a3ab
Compare
1ee4a16
to
1e52d2f
Compare
7d8a3ab
to
1973627
Compare
5a78983
to
16178af
Compare
1973627
to
914749f
Compare
914749f
to
cdeb4ca
Compare
cdeb4ca
to
fa4657b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are intentional. We use theme.pillBackgroundSelected
throughout the app as background colors for pills so doing the same here.
6085c57
to
bcde9ac
Compare
Happy to review this, but it looks like e2e tests are still failing. |
38fba26
to
584b160
Compare
@MatissJanis I'm encountering a weird issue where in the VRT tests, when clicking the Add button on the new transaction, it won't add the transaction. But when I open in a browser and do the same it does add the transaction. Any ideas? |
I think the problem is with creating transfers. When I click "create transfer" (inside account selection dropdown) - the popover just closes. |
584b160
to
a230834
Compare
@MatissJanis The problem is the Notes filter. In playwright, when the Apply button is clicked it's not reflecting the "Test Acc Transfer" that was typed in the input field - it just filters "(nothing)". What's weird is it works when I manually test it. Filter Notes: |
So there might be multiple problems with then PR then. This is the one I'm seeing: Screen.Recording.2024-07-09.at.08.58.30.mov |
a230834
to
efeacb7
Compare
efeacb7
to
58b57ae
Compare
Looks like there is something with the interaction between the autocomplete Popover and the "Make Transfer"/"Manage Payees" Button inside the Popover. It could be treating the the click as a "click outside" - not exacrly sure what is happening. Any ideas @MatissJanis? I'll move to migrate other parts of the code first and do the autocomplete and filters migration last. |
Ok, so looked into this more. What happens is:
AFAIK there is no way to control the focus logic for the react-aria button component. So my only other option is to use a link here ( |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
No description provided.