Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to find DOM elements #13

Closed
aculligan opened this issue Jul 2, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@aculligan
Copy link
Owner

commented Jul 2, 2019

Extension is unable to find DOM elements when a views page is reloaded. This is because Zendesk can take a long time to load all the elements, especially tickets in views.

This has been addressed in the past by setting a timeout before extension loads, but that creates a bad UX when the page does load fast enough.

@aculligan aculligan self-assigned this Jul 2, 2019

@aculligan

This comment has been minimized.

Copy link
Owner Author

commented Jul 2, 2019

Removed setTimeout and added setInterval, making sure the app wouldn't get caught in an endless loop in pages with no tickets or priority column.

Having the extension check for DOM elements on a time interval uses way less resources than using Mutation Observer to detect changes in the page.

Will deploy with v1.2.0

@aculligan aculligan closed this Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.