Skip to content

feat: Add addional GH token descriptor name#375

Merged
ZPascal merged 1 commit into
masterfrom
issue-56
May 23, 2026
Merged

feat: Add addional GH token descriptor name#375
ZPascal merged 1 commit into
masterfrom
issue-56

Conversation

@ZPascal
Copy link
Copy Markdown
Collaborator

@ZPascal ZPascal commented May 23, 2026

Support token as primary input name

Adds token as the preferred input name, aligning with the naming convention used by actions/checkout. The existing github_token input continues to work as a fallback for backwards compatibility.

Usage

- uses: ad-m/github-push-action@master
  with:
    token: ${{ secrets.GITHUB_TOKEN }}

Changes

  • token is resolved first, falling back to github_token if not set
  • Updated error message to reference token
  • No breaking changes — existing workflows using github_token are unaffected

Issue

fix: #56

Test

@ZPascal ZPascal requested a review from Copilot May 23, 2026 16:10
@ZPascal ZPascal self-assigned this May 23, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for a token input name (matching common GitHub Actions conventions) while keeping github_token for backwards compatibility, and updates the wrapper logic/docs accordingly.

Changes:

  • Introduces a new token input in action.yml.
  • Resolves auth token in start.js via INPUT_TOKEN || INPUT_GITHUB_TOKEN and forwards it to start.sh.
  • Updates README usage examples and inputs table; updates the missing-token error message.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
action.yml Adds new token input (but current defaults create a precedence regression).
start.js Resolves token from token/github_token and forwards the resolved token to the shell script.
start.sh Updates the missing-token error message to reference token.
README.md Documents token usage and adds token to the inputs table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread action.yml Outdated
Comment thread README.md Outdated
Comment thread start.sh
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread action.yml
Signed-off-by: Pascal Zimmermann <pascal.zimmermann@theiotstudio.com>
@ZPascal ZPascal marked this pull request as ready for review May 23, 2026 18:27
@ZPascal ZPascal requested a review from ad-m May 23, 2026 18:27
@ZPascal
Copy link
Copy Markdown
Collaborator Author

ZPascal commented May 23, 2026

@ad-m or @jackton1, could you please take a look at the change? What do you think of it?

@ZPascal ZPascal merged commit f917f9b into master May 23, 2026
@ZPascal ZPascal deleted the issue-56 branch May 23, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants