Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support for PIC32 architecture (chipKIT/MPIDE) #7

Closed
EmbeddedMan opened this Issue Sep 22, 2012 · 6 comments

Comments

Projects
None yet
2 participants
Contributor

EmbeddedMan commented Sep 22, 2012

It sure would be neat if this shield worked for chipKIT boards too.

Owner

ladyada commented Oct 9, 2012

It would! But we don't provide support for chipKit boards - Digilent has a staff of people for porting libraries - please post up in the chipkit forums :)

@ladyada ladyada closed this Oct 9, 2012

Contributor

EmbeddedMan commented Oct 9, 2012

Hi Adafruit - to the best of my knowledge, Digilent isn't porting any
libraries (except for the core libraries that come with the standard
Arduino IDE) - that's being left up to us, the 'community'. I have already
posted an announcement of my efforts to the chipKIT/MPIDE forums.

I will just make my Github repo the permanent home of the version of the
Ada Fruit Motor shield library that works with both AVR and PIC32, if
that's OK with you.

*Brian

On Tue, Oct 9, 2012 at 11:27 AM, Limor Ladyada Fried <
notifications@github.com> wrote:

It would! But we don't provide support for chipKit boards - Digilent has a
staff of people for porting libraries - please post up in the chipkit
forums :)


Reply to this email directly or view it on GitHubhttps://github.com/adafruit/Adafruit-Motor-Shield-library/issues/7#issuecomment-9268351.

Owner

ladyada commented Oct 9, 2012

Ah got it - well - if you can make it so it supports both cleanly using #ifdefs and such - ill take a pull request. I thought you were asking me to write the code & we don't have any PIC experts here

Contributor

EmbeddedMan commented Oct 9, 2012

Yes! Maybe I'm using Github wrong here - but I was told that you should
always create an issue that describes the problem you are trying to solve
with the pull request, and then refer to that issue in your pull request
text so that when the repo admin does a release, they can say that the
issue was fixed by the merge resulting from the pull request.

In any case, I'll be your PIC32 expert in this case. I have added (using
appropriate #ifdefs) PIC32 support to your library, and have tested it on
AVR and PIC32 and both work properly. So this is just a 'please merge my
code changes into the official repo' rather than a request for you to do
any work. And of course test the merge on AVR to make sure I didn't miss
something.

I will also have an update in the (near-ish) future for you: I discovered a
bug in the microstep sequence (for both AVR and PIC32 - the common code)
that I'll fix and issue another pull-request. But that may not happen for a
couple weeks.

P.S. I had a 2-stepper microstep demo running at the Microchip booth at
MFNY running on a chipKIT UNO32 with your motor shield on top - it ran all
day both days with nary a problem using the updated library.

*Brian

On Tue, Oct 9, 2012 at 1:15 PM, Limor Ladyada Fried <
notifications@github.com> wrote:

Ah got it - well - if you can make it so it supports both cleanly using
#ifdefs and such - ill take a pull request. I thought you were asking me to
write the code & we don't have any PIC experts here


Reply to this email directly or view it on GitHubhttps://github.com/adafruit/Adafruit-Motor-Shield-library/issues/7#issuecomment-9272859.

Owner

ladyada commented Oct 9, 2012

OK, issues are usually where people hassle me for bug fixes ;)
i see the pull request now, ill check it out and merge it shortly!

@ladyada ladyada added a commit that referenced this issue Oct 9, 2012

@ladyada ladyada Merge pull request #8 from EmbeddedMan/master
Add support for PIC32 architecture (fixes issue #7)
4bd21ca
Contributor

EmbeddedMan commented Oct 9, 2012

Thanks so much! And it was super awesome to see you guys when you stopped
by the Fubar Labs table and said hi.

Later-
*Brian

On Tue, Oct 9, 2012 at 2:07 PM, Limor Ladyada Fried <
notifications@github.com> wrote:

OK, issues are usually where people hassle me for bug fixes ;)
i see the pull request now, ill check it out and merge it shortly!


Reply to this email directly or view it on GitHubhttps://github.com/adafruit/Adafruit-Motor-Shield-library/issues/7#issuecomment-9274886.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment