Library fixes #12

Closed
wants to merge 1 commit into from

2 participants

@janoc

Hello,

I have made two small fixes to the lib to make it work with newer AVR gcc than what Arduino ships and to make the display bias parametrizable. My display is from Sparkfun and goes all black with the default bias of 0x4 but works fine with 0x1.

  • Fix compilation error (PROGMEM needs to be const with newer gcc)
  • Added bias to the arguments of begin(), my display goes all black with 0x4 after a while. It works with 0x1. Some people even use 0x14, 0x15. It obviously depends on display.
Jan Ciger Compilation fix, added bias as parameter
- Fix compilation error (PROGMEM needs to be const with newer gcc)
- Added bias to the arguments of begin(), my display goes all black with 0x4 after a while.
  It works with 0x1. Some people even use 0x14, 0x15. It obviously depends on display.
7a35e4d
@tdicola

Thanks for contributing this pull request. I'm going through and cleaning up old issues, and will close this one because the font data was refactored out of this library and into the Adafruit_GFX library (with this pull: b391f4a ). For the bias argument change, feel free to submit a new pull request based on the current state of the library. Thanks!

@tdicola tdicola closed this May 23, 2014
@tdicola
@janoc

Unfortunately I don't have the hardware available anymore, so I cannot update the library on my side. You may want to consider adding the bias fix yourselves as it helps make some of the cheaper modules to work.

@tdicola

No problem, I just put this fix into this pull: #23 Thanks again for suggesting the fix and sorry it couldn't be integrated sooner.

@janoc

Cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment