Add support for reading back string replies to AT commands#56
Merged
Conversation
hathach
approved these changes
Oct 6, 2020
hathach
left a comment
hathach
left a comment
Member
There was a problem hiding this comment.
Look great, thank you very much for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two (pairs of) helper functions to Adafruit_ATParser to allow the user to read back results from AT commands that return string values (e.g.,
AT+GATTLIST). (They come in pairs takingchar*andFlashStringHelper*command params.)No existing code was modified; only these functions were added.
I have tested this code inside a personal project still pending release running on the Feather 32u4 Bluefruit LE, and only in the narrow use case of checking the output from
AT+GATTLIST, but it works fine there. I have not tested it on any other platforms.