Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading back string replies to AT commands #56

merged 1 commit into from Oct 6, 2020


Copy link

@ihaque ihaque commented Oct 4, 2020

This PR adds two (pairs of) helper functions to Adafruit_ATParser to allow the user to read back results from AT commands that return string values (e.g., AT+GATTLIST). (They come in pairs taking char* and FlashStringHelper* command params.)

No existing code was modified; only these functions were added.

I have tested this code inside a personal project still pending release running on the Feather 32u4 Bluefruit LE, and only in the narrow use case of checking the output from AT+GATTLIST, but it works fine there. I have not tested it on any other platforms.

@ladyada ladyada requested a review from hathach October 5, 2020 15:47
Copy link

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, thank you very much for this PR.

@hathach hathach merged commit e659770 into adafruit:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants