Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #39 #41

Open
wants to merge 3 commits into
base: master
from

Conversation

@razinc
Copy link

razinc commented Oct 12, 2019

Please feedback if any requirements are not fulfilled. Thanks.

razinc added 3 commits Oct 12, 2019
Match file changes.
Copy link
Contributor

tannewt left a comment

Please rename one of these to ads1x15_simpletest.py so the script can identify it. The other can remain the same. Thanks for the change!

@caternuson

This comment has been minimized.

Copy link
Contributor

caternuson commented Oct 14, 2019

As another idea - how about just having a single file ads1x15_simpletest.py that has the code for both ADS1015 and ADS1115 with the lines for one of them commented out? And a code comment that says something like # uncomment the lines for the version you have.

Could the import be done in a more agnostic way to help reduce the number of lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.