Built-in Gamma Correction #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
May 17, 2018
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Doesn't this have a name conflict between gamma_correct the function and gamma_correct the boolean?
Contributor
|
@mcscope Is this something you're still interested in implementing? If so, please address the requested changes, as well as the travisci failure. If not, please let me know so we can close the PR. If I don't hear back from you, I will proceed with closing it - it can always be reopened or resubmitted. Thanks! |
Contributor
|
Closing. Please reopen or create a new PR if you want to implement this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21
This is how I'd do gamma correction built-in. Haven't tested this on hardware yet.
I'll probably get dinged on 'too many instance variables' cause IIRC Dotstar was already at the maximum.