Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _pixelbuf support #42

Open
wants to merge 12 commits into
base: master
from
Open

Add _pixelbuf support #42

wants to merge 12 commits into from

Conversation

@rhooper
Copy link

rhooper commented Dec 2, 2019

No description provided.

@rhooper rhooper force-pushed the rhooper:pixelbuf branch from a9678ed to 010e691 Jan 8, 2020
.pylintrc Outdated
@@ -18,6 +18,7 @@ ignore-patterns=
#init-hook=

# Use multiple processes to speed up Pylint.
# jobs=1

This comment has been minimized.

Copy link
@siddacious

siddacious Jan 8, 2020

Contributor

Looks like there is a bunch of commented out changes; just make sure to remove them before you're done.

@siddacious

This comment has been minimized.

Copy link
Contributor

siddacious commented Jan 9, 2020

@rhooper Since pypixelbuf and the API changes were both merged, is this no longer WIP and ready to merge? I took a look and it's good from what I can tell but it may be wise to have someone more familiar with the code. In the meanwhile I'll do some testing

@rhooper

This comment has been minimized.

Copy link
Author

rhooper commented Jan 10, 2020

This is no longer a wip

@makermelissa makermelissa changed the title WIP: Add _pixelbuf support Add _pixelbuf support Jan 10, 2020
@siddacious

This comment has been minimized.

Copy link
Contributor

siddacious commented Jan 10, 2020

Before someone else merges, might be worth mentioning this issue in the NeoPixel repo that popped up:
adafruit/Adafruit_CircuitPython_NeoPixel#65
I'm not sure how similar the DotStar implementation is to the NeoPixel one but perhaps DotStar has the same issue?

Copy link
Contributor

tannewt left a comment

A couple things. Otherwise this looks very cool!

@@ -15,7 +15,7 @@
'sphinx.ext.viewcode',
]

# autodoc_mock_imports = ["digitalio", "busio"]
autodoc_mock_imports = ["pypixelbuf"]

This comment has been minimized.

Copy link
@tannewt

tannewt Jan 10, 2020

Contributor

Is this needed? Can't the real version be installed from pypi?

`Feather M4 Express <https://www.adafruit.com/product/3857>`_ and
`DotStar FeatherWing <https://www.adafruit.com/product/3449>`_.

.. code-block:: python

This comment has been minimized.

Copy link
@tannewt

tannewt Jan 10, 2020

Contributor

I think this example would be better to have in a separate example file. The example in the readme should be short and simple. Other examples can do fancier things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.