Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secrets.py for ssid and password. #88

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@tannewt
Copy link
Contributor

tannewt commented Jan 31, 2020

No description provided.

@ladyada

This comment has been minimized.

Copy link
Member

ladyada commented Jan 31, 2020

we'd have to update the guide as well

@tannewt

This comment has been minimized.

Copy link
Contributor Author

tannewt commented Jan 31, 2020

Yup, there are big warnings to manually replace them but it felt weird after setting up the secrets file. I'm curious why it is that way.

@ladyada

This comment has been minimized.

Copy link
Member

ladyada commented Jan 31, 2020

used to come before the secrets file, perhaps it got rearranged - @brentru any feelings either way?

@dhalbert

This comment has been minimized.

Copy link
Contributor

dhalbert commented Jan 31, 2020

There was a warning below the example; I put another warning above, after helping someone on discord (and being confused myself).

@brentru

This comment has been minimized.

Copy link
Member

brentru commented Jan 31, 2020

@ladyada I'm OK with this update, it'll reduce confusion.

The Internet Connect! page lists the secrets.py setup step (https://learn.adafruit.com/adafruit-pyportal/internet-connect#whats-a-secrets-file-17-1) step before the Connect to WiFi step.

Once merged and released, I'll change text on the Connect to WiFi (https://learn.adafruit.com/adafruit-pyportal/internet-connect#connect-to-wifi-17-4) step to reflect the updated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.