Skip to content

Conversation

@pbricmont
Copy link

Tested against the Adafruit HT16K33 Breakout (PID: 1427) + 4 Dual Alphanumeric Displays (PID: 1907) using CircuitPython 3.1.2 & 4.0.0 RC1 on the Metro M0 Express, Metro M4 Express and 4.0.0 RC1 on the Metro M4 Grand Central. Also tested against a custom board based the Adafruit Alphanumeric LED Backpack. Closes issue #36.

@sommersoft sommersoft requested a review from a team May 4, 2019 03:09
@sommersoft
Copy link
Collaborator

@adafruit/circuitpythonlibrarians,

I have an open question on this:

  • Would it be better to include the Seg14x8 class in the current segment.py with the other classes?
  • Or, since this is not an Adafruit product (per se), is it better broken out in its own file?

I know, technically two questions...

@caternuson
Copy link
Contributor

Would it be better to include the Seg14x8 class in the current segment.py with the other classes?

I think so. That would follow the existing layout.

Or, since this is not an Adafruit product (per se), is it better broken out in its own file?

Maybe. Could be in the community bundle?

@tannewt
Copy link
Member

tannewt commented May 9, 2019

Community bundle is my preference. I'd really like to see chip drivers split from specific uses like the matrix defs.

@pbricmont pbricmont closed this Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants