Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
segments: Add missing API for "dot" control on big 7-segments #41
There are 4 side LEDs around the 4 7-segments on 1.2" packages of HT16k33
There already was setter and getter to control "ampm" dot (the one at the
There are 4 side LEDs around the 4 7-segments on 1.2" packages of HT16k33 (https://www.adafruit.com/product/1270). This commit adds an API to control them (set and get). There already was setter and getter to control "ampm" dot (the one at the top-right). This API is still working but now use the new added functions.
tannewt left a comment
Thank you for this change!
In general we avoid get/set methods because they can be implemented with properties (like
I'd recommend adding two more properties for top_left_dot and bottom_left_dot that are implemented like ampm. You can use your new get/set methods internally by adding an _ to the start of the name. The other way do do it is by using a data descriptor class for all three.