Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timed animation #67

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

gamblor21
Copy link
Member

@gamblor21 gamblor21 commented Sep 28, 2020

A animation sequence that lets you specify how long each animation runs, individually. Allows for more fine grained control of the cycle of animations (good for syncing to music).

@gamblor21
Copy link
Member Author

gamblor21 commented Sep 28, 2020

I'm not sure why but somehow putting a PR for this branch too included the changes I had with the other PR branch. Not sure if I should just delete the extra "volume.py" file here?

@tannewt tannewt requested a review from kattni Sep 29, 2020
@jposada202020
Copy link

jposada202020 commented May 13, 2021

@kattni I think this is read, could you take a look thanks :)

@evaherrada evaherrada changed the base branch from master to main Jun 7, 2021
Copy link
Member

@kattni kattni left a comment

@gamblor21 Hey! We're taking a look at this now. You submitted it before we started using the reuse licensing. Please update the licensing along with any possible suggestions we may have regarding the code.

I would suggest running it through pre-commit to make sure it fits with our current standards.

@kattni
Copy link
Member

kattni commented Oct 31, 2021

I'm not sure why but somehow putting a PR for this branch too included the changes I had with the other PR branch. Not sure if I should just delete the extra "volume.py" file here?

Regardless of which PR is merged first, it will likely cause merge conflicts to have that file in here, as well as causing issues if any changes are needed on the other PR. I would suggest deleting the volume.py file from this PR.

@rhooper
Copy link

rhooper commented Oct 31, 2021

@gamblor21 i have been thinking about this PR. It has reminded me that I feel like the current auto-advance API is a bit convoluted. Instead of a new sequence class, I feel like having Animation instances be in control of their advancement behaviour would be better. Thus refactoring Animation, AnimationGroup, and AnimationSequence would make it all much more flexible and less complicated to use.

I can be more specific if you agree.

@gamblor21
Copy link
Member Author

gamblor21 commented Dec 6, 2021

Just a note that I have not forgot about this PR and hope to take a look at the comments soon. @rhooper I'm not 100% sure what you mean changing the advancement but you know this area better then I do. My main use of this was to run have short animations run repeatedly for a period of time that was synced to music playing. E.g. Rainbow affect for 15 seconds then key change and start a blinking pattern.

I am willing to look at refactoring things if there is a better way to do so for the future.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Apr 25, 2022

Checking in on these, @gamblor21 you still have these new animation PRs on your radar?

I think it would be great to include an example script illustrating the new animations when they are added as well.

@gamblor21
Copy link
Member Author

gamblor21 commented Apr 25, 2022

Checking in on these, @gamblor21 you still have these new animation PRs on your radar?

I think it would be great to include an example script illustrating the new animations when they are added as well.

They are still on my radar (I have browser tabs open to the PRs). I will try to make time to take a look at them in the next couple weeks or so.

@kattni
Copy link
Member

kattni commented Apr 25, 2022

I believe part of the concern is that we're trying to work on keeping this library a bit slimmer. However, on some level, adding more animations isn't a huge issue since they're in separate modules already. @rhooper plans to make some changes to this library over the weekend, in the core and helper areas, if there is time to be had. She can also take another look at these animation PRs as well while looking into the rest of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants