Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mcp9808_simpletest.py #20

Open
wants to merge 2 commits into
base: master
from

Conversation

@signalmeister
Copy link

signalmeister commented Sep 28, 2019

The original example code did not show the syntax for setting up a module with anything other than the default address. While this information is to be found in the object definition document, a simple amendment to the sample code gives the default and an amended address example.

The original example code did not show the syntax for setting up a module with anything other than the default address. While this information is to be found in the object definition document, a simple amendment to the sample code gives the default and an amended address example.
Copy link
Contributor

tannewt left a comment

Thank you for the PR! Unfortunately, the lint check is unhappy due to the comments at the end of the lines with the object construction. I don't think they are needed because of the comments on the previous lines so I'd suggest removing them.

In the second example constructor I'd also suggest address=0x19 to make it a bit more readable. Thanks!

I am not really sure that I understood your comments being a total novice at this process - I do not know what a lint check being unhappy means.
If there are still issues, can you please let me know and I hope I can understand your special terms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.