Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mlx90640_pygamer.py #7

Merged
merged 2 commits into from Jan 14, 2020
Merged

Update mlx90640_pygamer.py #7

merged 2 commits into from Jan 14, 2020

Conversation

@dglaude
Copy link
Contributor

dglaude commented Jan 8, 2020

Use simpleio.map_range, remove custom function, more comments, cleaning, rename to max_t and min_t, general improvement.

No new functionality, just possibly easier to understand code and removing a custom function doing map_range.

dglaude added 2 commits Jan 8, 2020
Use simpleio.map_range, remove custom function, more comments, cleaning, rename to max_t and min_t, general improvement.
Making pylint happy...
@dglaude

This comment has been minimized.

Copy link
Contributor Author

dglaude commented Jan 8, 2020

This should fix #6

@tannewt tannewt requested a review from adafruit/circuitpythonlibrarians Jan 10, 2020
@caternuson

This comment has been minimized.

Copy link
Contributor

caternuson commented Jan 13, 2020

Looks good. Did you also test just to make sure it all still runs as expected?

@dglaude

This comment has been minimized.

Copy link
Contributor Author

dglaude commented Jan 14, 2020

Yes, I have recovered my hardware and it was tested.

Actually, I never tested on Adafruit Stemma/breakout but only on my older Pimoroni Breakout Garden version. This is why I would love to see someone plugging a Stemma cable between a PyGamer and the Adafruit mlx90640 breakout board. (please take a picture).

I also have a PyPortal, so I may do a version with that resolution (but first I need to find/build a Stemma to Pimoroni Breakout Garden cable).

@caternuson

This comment has been minimized.

Copy link
Contributor

caternuson commented Jan 14, 2020

OK. Those are just different ways of making the I2C connection. So shouldn't really matter in terms of testing the code. As long as you had some hardware setup for testing, should be fine.

@caternuson caternuson merged commit 0ee7b6f into adafruit:master Jan 14, 2020
1 check passed
1 check passed
test
Details
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 15, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.6.0 from 2.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#47 from makermelissa/marquee
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#49 from makermelissa/matrix_scroll
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#41 from vdehors/master
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#46 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 2.0.0 from 1.0.0:
  > Update README.rst
  > Update README.rst
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#2 from adafruit/lsm6ds_refactor
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#1 from adafruit/dherrada-patch-1
  > added additional rates & sensor identifier

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#7 from dglaude/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#8 from caternuson/iss2
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#5 from dglaude/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#4 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.9.4 from 1.9.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#51 from makermelissa/master
  > update pylint examples directive
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#50 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#24 from caternuson/iss23

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_LSM6DS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.