Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1, Example needs renaming to match lib name #5

Open
wants to merge 1 commit into
base: master
from

Conversation

@geekguy-wy
Copy link

geekguy-wy commented Feb 10, 2020

Renamed tap_example.py to msa301_tap_example.py so it matches the library name. Added msa301_tap_example.py to docs/examples.rst.

@dherrada

This comment has been minimized.

Copy link
Contributor

dherrada commented Feb 10, 2020

Hi @geekguy-wy. Thanks for your contribution! I would approve and merge it, but since #4 was opened before this one, I'm going to work with the author of that PR to get theirs right. If the author of that PR doesn't make the requested changes, I'll be happy to reopen and merge this PR, but for now, I'm going to close it.

P.S. If you'd like to do essentially the same thing on a different library, PyPixelbuf also needs an example renamed.

@dherrada dherrada closed this Feb 10, 2020
@dherrada dherrada reopened this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.