Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixelbuf support #74

Open
wants to merge 5 commits into
base: master
from
Open

Pixelbuf support #74

wants to merge 5 commits into from

Conversation

@rhooper
Copy link
Contributor

rhooper commented Feb 21, 2020

This MR adds support for _pixelbuf.

Notable is that this means .buf is gone. The way _pixelbuf works now means there is no .buf property. In theory we can emulate that with a @Property.

rhooper added 3 commits Feb 21, 2020
This reverts commit 10db851, reversing
changes made to 68388d0.
@rhooper rhooper force-pushed the rhooper:pixelbuf branch from a5057b8 to 9fba7b6 Feb 21, 2020
@tannewt

This comment has been minimized.

Copy link
Contributor

tannewt commented Feb 24, 2020

Thanks for adding this! I'd like to wait to merge until 5.x is stable because 4.x crashes.

@dunkmann00

This comment has been minimized.

Copy link

dunkmann00 commented Mar 19, 2020

Is this good to be merged now that CP is at 5.0?

@dunkmann00

This comment has been minimized.

Copy link

dunkmann00 commented Mar 29, 2020

@kattni Any plans for when this can be merged back in?

@tannewt

This comment has been minimized.

Copy link
Contributor

tannewt commented Mar 30, 2020

@dunkmann00 We don't have any immediate plans though we should be able to do it. Maybe we can once @rhooper dusts off the PR? I may have a variant somewhere here too. It'd be good if it fell back to PyPixelBuf based on the CircuitPython major version instead of whether _pixelbuf is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.