Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing font file and font file location #6

Closed
jerryneedell opened this issue Jun 23, 2019 · 5 comments
Closed

missing font file and font file location #6

jerryneedell opened this issue Jun 23, 2019 · 5 comments

Comments

@jerryneedell
Copy link
Contributor

jerryneedell commented Jun 23, 2019

I tried running the demo for this and ran into 2 issues with this line
https://github.com/adafruit/Adafruit_CircuitPython_PYOA/blob/master/adafruit_pyoa.py#L75

First, I don't have this font file Arial-Bold-12-- where can I get it?
I do have Arial-12 so I temproarily used it then I found that this assumes the file is at the root level of the filesystem. Isn't the convention to put fonts in a fonts/ folder?

@jerryneedell
Copy link
Contributor Author

#7 fixes the missing file - thanks
regarding the location of the font file, I wonder if this should be passed in as an argument so the user can decide where to keep the file -- this will be especially useful if the whole example is stored on an SD card.

Having adafruit_pyoa.py assume a location may be to restrictive.

@ladyada
Copy link
Member

ladyada commented Jun 23, 2019

taggin @dastels

@dastels
Copy link
Collaborator

dastels commented Jun 23, 2019

2 thoughts:

  1. we could pass the font directory into the constructor of PYOA_Graphics
  2. we could have the font directory in the game asset directory (e.g. cyoa/fonts and cave/fonts)

The later has the benefit of not requiring any code changes outside the lib code as well as packaging everything for the game together.

@ladyada
Copy link
Member

ladyada commented Jun 23, 2019

latter plz

@kattni
Copy link
Contributor

kattni commented May 1, 2020

This appears to have been resolved.

@kattni kattni closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants