Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0.42" Screen Compatibility #36

Open
wants to merge 3 commits into
base: master
from

Conversation

@TinyCircuits
Copy link

TinyCircuits commented Dec 30, 2019

@ladyada

This comment has been minimized.

Copy link
Member

ladyada commented Dec 30, 2019

this seems to break existing OLEDs by changing mapping - please test against existing supported ones

@TinyCircuits

This comment has been minimized.

Copy link
Author

TinyCircuits commented Dec 30, 2019

Sorry! We minimized the changes from the original, changes should only apply to unsupported screens now.

@ladyada ladyada requested a review from adafruit/circuitpythonlibrarians Dec 30, 2019
@tannewt

This comment has been minimized.

Copy link
Contributor

tannewt commented Jan 2, 2020

Thanks for this! Let me know if you need help adding CircuitPython board defs for TinyCircuits boards!

I'd suggest adding a new keyword argument called colstart (this is the same name as the native display support) to the __init__ method instead of assuming a shift of 28 with a given width. It's really just an artifact of how the display manufacturer hooked the IC up to the display circuitry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.