-
Notifications
You must be signed in to change notification settings - Fork 3
Trackpad #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RetiredWizard
wants to merge
3
commits into
adafruit:main
Choose a base branch
from
RetiredWizard:trackpad
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Trackpad #9
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like obscuring the use of None here. Instead, just use bare none below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was being a bit lazy when I used None, I didn't know if there was a subclass ID for REPORT devices or if there were any other subclass IDs. Assuming google AI can be trusted, it looks like 0x00 might be the correct choice.
No, there is not a specific constant for
SUBCLASS_REPORT. The HID class defines only one optional subclass: the Boot Interface Subclass (0x01).
If a device does not support the boot interface subclass, its subclass field in the interface descriptor is set to 0x00, which signifies that it operates using the standard Report Protocol. The value 0x00 effectively represents the "Report" subclass, but it is typically referred to as the "No Subclass" or "Reserved" value in the USB specifications, with the absence of the boot code indicating the use of the full report descriptor method.
In summary, the relevant subclass constants are:
It's easy enough to pull the constant and just pass None as you suggested but what do you think of using 0x00 instead?