From e363928ffa08433abded643f3de8db6ec023393b Mon Sep 17 00:00:00 2001 From: KingPharoo Date: Sat, 2 Dec 2023 06:36:46 +0000 Subject: [PATCH] Updated after review 1 --- adafruit_platformdetect/board.py | 9 ++++----- adafruit_platformdetect/constants/boards.py | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/adafruit_platformdetect/board.py b/adafruit_platformdetect/board.py index 145139c..7ecb16e 100644 --- a/adafruit_platformdetect/board.py +++ b/adafruit_platformdetect/board.py @@ -702,7 +702,7 @@ def _allwinner_variants_id(self) -> Optional[str]: # TODO: Add other specifc board contexts here elif "lime2" in board_value: - board = boards.LIME2 + board = boards.OLIMEX_LIME2 return board # pylint: disable=too-many-return-statements @@ -931,9 +931,9 @@ def any_nxp_navq_board(self) -> bool: return self.id in boards._NXP_SOM_IDS @property - def any_lime2_board(self): + def any_olimex_lime2_board(self): """Check whether the current board is any Pine64 device.""" - return self.id in boards.LIME2 + return self.id in boards.OLIMEX_LIME2 @property def os_environ_board(self) -> bool: @@ -955,7 +955,6 @@ def lazily_generate_conditions(): yield self.board.QTPY_U2IF yield self.board.QT2040_TRINKEY_U2IF yield self.board.KB2040_U2IF - yield self.board.lime2 return any(condition for condition in lazily_generate_conditions()) @@ -998,7 +997,7 @@ def lazily_generate_conditions(): yield self.generic_linux yield self.any_nxp_navq_board yield self.any_walnutpi - yield self.any_lime2_board + yield self.any_olimex_lime2_board return any(condition for condition in lazily_generate_conditions()) diff --git a/adafruit_platformdetect/constants/boards.py b/adafruit_platformdetect/constants/boards.py index db1d419..af43d02 100644 --- a/adafruit_platformdetect/constants/boards.py +++ b/adafruit_platformdetect/constants/boards.py @@ -24,7 +24,7 @@ BEAGLELOGIC_STANDALONE = "BEAGLELOGIC_STANDALONE" OSD3358_DEV_BOARD = "OSD3358_DEV_BOARD" OSD3358_SM_RED = "OSD3358_SM_RED" -LIME2 = "LIME2" +OLIMEX_LIME2 = "OLIMEX_LIME2" FEATHER_HUZZAH = "FEATHER_HUZZAH" FEATHER_M0_EXPRESS = "FEATHER_M0_EXPRESS" GENERIC_LINUX_PC = "GENERIC_LINUX_PC"