Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add html_colors as displayio hex to helpers #18

Open
wants to merge 1 commit into
base: master
from

Conversation

@TG-Techie
Copy link

TG-Techie commented Jul 10, 2019

No description provided.

@ladyada

This comment has been minimized.

Copy link
Member

ladyada commented Jul 10, 2019

please fix travis

@ladyada

This comment has been minimized.

Copy link
Member

ladyada commented Jul 12, 2019

@TG-Techie do you need help gettin' this to pass?

@TG-Techie

This comment has been minimized.

Copy link
Author

TG-Techie commented Jul 13, 2019

I gave it a shot and I would like some help, thank you.

@ladyada

This comment has been minimized.

Copy link
Member

ladyada commented Jul 13, 2019

ok the travis error is

Generating VERSIONS
fatal: No names found, cannot describe anything.
Stopping at 'helpers/html_colors'; script returned non-zero status.
Failed to generate versions file. Its likely a library hasn't been released yet.
WARNING: some failures above

whatcha think is wrong?

@TG-Techie

This comment has been minimized.

Copy link
Author

TG-Techie commented Jul 13, 2019

The 'name' error is Still puzzling. However, I would hypothesize that the 'failed to generate versions file. It's likely...' means that "0.0.0-auto0" is not a valid version number?

@ladyada

This comment has been minimized.

Copy link
Member

ladyada commented Jul 13, 2019

its sayin "Its likely a library hasn't been released yet."
did you release your library?

@TG-Techie

This comment has been minimized.

Copy link
Author

TG-Techie commented Jul 13, 2019

Ah🤦‍♂️, no. Can do(doing...)

@brentru

This comment has been minimized.

Copy link
Member

brentru commented Aug 8, 2019

@TG-Techie Could you try bumping the release version on _html_colors to a numbered tag, such as v1.0?

Currently it's beta0_travis.
https://github.com/TG-Techie/adafruit_circuitpython_html_colors/releases/tag/beta0_travis

@sommersoft

This comment has been minimized.

Copy link
Contributor

sommersoft commented Aug 8, 2019

You'll want the release tag to be in the Semantic Versioning format. 0.0.1, 1.0.0, 1.0.0-beta.1, etc.

After that, you'll need to update the submodule's tag to point to the release. Checking out master should point to the same commit as the release's tagged commit:

~/CircuitPython_Community_Bundle/ $: cd libraries/helpers/html_colors
~/CircuitPython_Community_Bundle/libraries/helpers/html_colors $: git checkout master
~/CircuitPython_Community_Bundle/libraries/helpers/html_colors $: git pull
~/CircuitPython_Community_Bundle/libraries/helpers/html_colors $: cd ../../..
~/CircuitPython_Community_Bundle/ $: git commit -a -m "<commit message>"
@ghost

This comment has been minimized.

Copy link

ghost commented Feb 26, 2020

@TG-Techie Have you released it yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.