Add CircuitPython_Waveform library #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
approved these changes
Mar 20, 2025
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Two options are fine with me.
Contributor
Author
|
@tannewt Cool. I just wanted to be transparent. 😸 |
Contributor
|
@relic-se The incorporation of your waveform helper into the Community Bundle is a welcome addition! It makes it easy to create useful waveforms quickly with an intutitive API. WaveBuilder has some similar functionality, but was designed to employ additive synthesis to create relatively complex waveform samples. |
Contributor
Author
|
Thanks for the affirmation, @CedarGroveStudios! I do agree that users can benefit from both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple helper library to generate waveforms commonly used by synthio.
I only just noticed that @CedarGroveStudios has already created a library similar to this one (https://github.com/CedarGroveStudios/CircuitPython_WaveBuilder) when adding my library to the list. The library I created has a different API approach and the additional feature of working with .wav files, but otherwise both libraries are capable of producing just about the same result. I am open to discussion about whether or not to include this library in the bundle.