Modified read speed #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced delay times from 250ms and 20ms to 1ms. This was done in accordance with the datasheet. E.G. no where does it say you need to wait 250ms or 20ms. It does say to set the line high for a minimum of 1ms (the second delay). This has been tested and is working in my of my projects
|
I was also surprised by the extremely high delay there blocking interactive parts of my project (TFT touch loop). However, maybe having delays at lowest limit is also not that good - but factor 2 (i.e., 2ms) should be IMHO sufficient, then the entire reading is done in 5ms, which is acceptable. Is there a way to vote for PRs to be merged? If so, you have +1 from me (after updating the delay). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced delay times from 250ms and 20ms to 1ms. This was done in accordance with the datasheet. The data sheet specifies only a minimum of 1 ms for the second delay. I've implemented this code in 3 projects with no negative affects