Skip to content

Add Deneyap Development Boards#1167

Merged
makermelissa merged 6 commits into
adafruit:mainfrom
deneyapkart:main
Mar 28, 2023
Merged

Add Deneyap Development Boards#1167
makermelissa merged 6 commits into
adafruit:mainfrom
deneyapkart:main

Conversation

@DogushC
Copy link
Copy Markdown
Contributor

@DogushC DogushC commented Mar 14, 2023

Add Deneyap Development Boards' info and images.

List of Deneyap Development Boards

  • Deneyap Kart
  • Deneyap Mini
  • Deneyap Kart 1A
  • Deneyap Kart G
  • Deneyap Mini v2
  • Deneyap Kart 1A v2

DogushC added 2 commits March 14, 2023 20:49
Add Deneyap Development Boards' info and images.

List of Deneyap Development Boards
Deneyap Kart
Deneyap Mini
Deneyap Kart 1A
Deneyap Kart G
Deneyap Mini v2
Deneyap Kart 1A v2
@tannewt
Copy link
Copy Markdown
Member

tannewt commented Mar 14, 2023

Do you have a PR to CircuitPython itself for support?

@DogushC
Copy link
Copy Markdown
Contributor Author

DogushC commented Mar 14, 2023

Do you have a PR to CircuitPython itself for support?

I would like to add a our development board to the circuitpython.org website.

@jepler
Copy link
Copy Markdown
Contributor

jepler commented Mar 14, 2023

The boards section on circuitpython.org is only for boards that have support in https://github.com/adafruit/circuitpython -- it does not list boards that are supported only in micropython, or only in a fork of circuitpython.

@DogushC
Copy link
Copy Markdown
Contributor Author

DogushC commented Mar 14, 2023

The boards section on circuitpython.org is only for boards that have support in https://github.com/adafruit/circuitpython -- it does not list boards that are supported only in micropython, or only in a fork of circuitpython.

That's right. If the PR will be merged, our boards will be listed in https://github.com/adafruit/circuitpython...
I followed the instruction in https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website

@tannewt
Copy link
Copy Markdown
Member

tannewt commented Mar 14, 2023

You'll need to do this first: https://learn.adafruit.com/how-to-add-a-new-board-to-circuitpython

@DogushC
Copy link
Copy Markdown
Contributor Author

DogushC commented Mar 14, 2023

You'll need to do this first: https://learn.adafruit.com/how-to-add-a-new-board-to-circuitpython

I see. Thanks.

@dhalbert
Copy link
Copy Markdown
Collaborator

I added a sentence to the https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website guide to say that adding the board to CircuitPython is a prerequisite.

@DogushC
Copy link
Copy Markdown
Contributor Author

DogushC commented Mar 14, 2023

I added a sentence to the https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website guide to say that adding the board to CircuitPython is a prerequisite.

Now we are working on adding our boards in CircuitPython repo. Will you close the PR or wait it until its done?

@makermelissa
Copy link
Copy Markdown
Collaborator

Now we are working on adding our boards in CircuitPython repo. Will you close the PR or wait it until its done?

I'll convert it to a draft PR and you can update it and fix the failing checks when you're ready.

@makermelissa makermelissa marked this pull request as draft March 15, 2023 20:53
@makermelissa
Copy link
Copy Markdown
Collaborator

It looks like it's failing because your descriptions have features that are different than out current standard set of feature filters. See https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-downloads for more info.

Update tags of features
@DogushC
Copy link
Copy Markdown
Contributor Author

DogushC commented Mar 28, 2023

It looks like it's failing because your descriptions have features that are different than out current standard set of feature filters. See https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-downloads for more info.

Done.

@DogushC DogushC marked this pull request as ready for review March 28, 2023 22:18
Copy link
Copy Markdown
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

@makermelissa makermelissa merged commit 9ccf9a5 into adafruit:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants