From eefb6842a02fede247d144ee9f29876efd584f7e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= Date: Sat, 18 Aug 2018 16:00:06 +0200 Subject: [PATCH] i2cslave: Fix missing translate() when raising exceptions The translate() changes where applied after travis had checked the i2cslave PR so this wasn't caught. --- ports/atmel-samd/common-hal/i2cslave/I2CSlave.c | 2 +- shared-bindings/i2cslave/I2CSlave.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ports/atmel-samd/common-hal/i2cslave/I2CSlave.c b/ports/atmel-samd/common-hal/i2cslave/I2CSlave.c index 0e68453df4442..f0bbed3d716ae 100644 --- a/ports/atmel-samd/common-hal/i2cslave/I2CSlave.c +++ b/ports/atmel-samd/common-hal/i2cslave/I2CSlave.c @@ -42,7 +42,7 @@ void common_hal_i2cslave_i2c_slave_construct(i2cslave_i2c_slave_obj_t *self, uint32_t sda_pinmux, scl_pinmux; Sercom *sercom = samd_i2c_get_sercom(scl, sda, &sercom_index, &sda_pinmux, &scl_pinmux); if (sercom == NULL) { - mp_raise_ValueError("Invalid pins"); + mp_raise_ValueError(translate("Invalid pins")); } self->sercom = sercom; diff --git a/shared-bindings/i2cslave/I2CSlave.c b/shared-bindings/i2cslave/I2CSlave.c index 2f3646d57a160..d2e001e4cefff 100644 --- a/shared-bindings/i2cslave/I2CSlave.c +++ b/shared-bindings/i2cslave/I2CSlave.c @@ -95,16 +95,16 @@ STATIC mp_obj_t i2cslave_i2c_slave_make_new(const mp_obj_type_t *type, size_t n_ while ((item = mp_iternext(iterable)) != MP_OBJ_STOP_ITERATION) { mp_int_t value; if (!mp_obj_get_int_maybe(item, &value)) { - mp_raise_TypeError("can't convert address to int"); + mp_raise_TypeError(translate("can't convert address to int")); } if (value < 0x00 || value > 0x7f) { - mp_raise_ValueError("address out of bounds"); + mp_raise_ValueError(translate("address out of bounds")); } addresses = m_renew(uint8_t, addresses, i, i + 1); addresses[i++] = value; } if (i == 0) { - mp_raise_ValueError("addresses is empty"); + mp_raise_ValueError(translate("addresses is empty")); } common_hal_i2cslave_i2c_slave_construct(self, scl, sda, addresses, i, args[ARG_smbus].u_bool);