Skip to content

i2cslave: Fix missing translate() when raising exceptions #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannewt merged 1 commit into from
Aug 20, 2018
Merged

i2cslave: Fix missing translate() when raising exceptions #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ports/atmel-samd/common-hal/i2cslave/I2CSlave.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ void common_hal_i2cslave_i2c_slave_construct(i2cslave_i2c_slave_obj_t *self,
uint32_t sda_pinmux, scl_pinmux;
Sercom *sercom = samd_i2c_get_sercom(scl, sda, &sercom_index, &sda_pinmux, &scl_pinmux);
if (sercom == NULL) {
mp_raise_ValueError("Invalid pins");
mp_raise_ValueError(translate("Invalid pins"));
}
self->sercom = sercom;

Expand Down
6 changes: 3 additions & 3 deletions shared-bindings/i2cslave/I2CSlave.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,16 @@ STATIC mp_obj_t i2cslave_i2c_slave_make_new(const mp_obj_type_t *type, size_t n_
while ((item = mp_iternext(iterable)) != MP_OBJ_STOP_ITERATION) {
mp_int_t value;
if (!mp_obj_get_int_maybe(item, &value)) {
mp_raise_TypeError("can't convert address to int");
mp_raise_TypeError(translate("can't convert address to int"));
}
if (value < 0x00 || value > 0x7f) {
mp_raise_ValueError("address out of bounds");
mp_raise_ValueError(translate("address out of bounds"));
}
addresses = m_renew(uint8_t, addresses, i, i + 1);
addresses[i++] = value;
}
if (i == 0) {
mp_raise_ValueError("addresses is empty");
mp_raise_ValueError(translate("addresses is empty"));
}

common_hal_i2cslave_i2c_slave_construct(self, scl, sda, addresses, i, args[ARG_smbus].u_bool);
Expand Down