Fix error messages in bleio#1692
Merged
Merged
Conversation
Collaborator
|
Travis failed due to translations in the first subjob. |
Author
|
Sorry, forgot to run make translate again. |
Collaborator
jerryneedell
left a comment
jerryneedell
left a comment
There was a problem hiding this comment.
question about error messages -- sorry I'm late
| m_tx_in_progress--; | ||
| mp_raise_OSError_msg_varg(translate("Failed to notify or indicate attribute value, err %0x04x"), err_code); | ||
| mp_raise_OSError_msg_varg(translate("Failed to notify or indicate attribute value, err x0%04x"), err_code); | ||
| } |
Collaborator
There was a problem hiding this comment.
shouldn't this be 0x%04x ?
| if (err_code != NRF_SUCCESS) { | ||
| mp_raise_OSError_msg_varg(translate("Failed to read attribute value, err %0x04x"), err_code); | ||
| mp_raise_OSError_msg_varg(translate("Failed to read attribute value, err x0%04x"), err_code); | ||
| } |
Collaborator
There was a problem hiding this comment.
same as above 0x%04x
Collaborator
|
Good point, @jerryneedell. I should have looked more carefully. @deshipu could you submit another PR? |
Author
|
Sure, sorry about that. Looks like those messages are cursed... |
Author
|
Done in #1699 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.