Rework the pixel computation to use areas #1903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the displayio pixel computation from per-pixel to per-area. This is precursor work to updating portions of the screen (micropython#1169). It should provide mild speedups because bounds checks are done once per area rather than once per pixel. Filling by area also allows TileGrid to maintain a row-associative fill pattern even when the display's refresh is orthogonal to it.
dhalbert
requested changes
May 22, 2019
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
I haven't tried to understand this in detail, but the basic ideas make sense to me.
tannewt
commented
May 22, 2019
Member
Author
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Please don't merge this. There is an off-by-one error that is apparent with the quotes demo and I'm out of time before vacation. Will fix it up at the end of next week.
It caused the bottom and right edges to be one pixel short.
Member
Author
|
Ok, I fixed the off-by-one error. This should be good to go if Travis is happy. |
dhalbert
approved these changes
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the displayio pixel computation from per-pixel to
per-area. This is precursor work to updating portions of the screen
(#1169). It should provide mild speedups because bounds checks are
done once per area rather than once per pixel. Filling by area also
allows TileGrid to maintain a row-associative fill pattern even when
the display's refresh is orthogonal to it.