-
Notifications
You must be signed in to change notification settings - Fork 1.4k
F411re feature buildout #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F411re feature buildout #2065
Conversation
|
@tannewt does that last error even have anything to do with my changes? It says it can't install python. |
|
I restarted that subjob. Sometimes the Travis instances are flaky. |
dhalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thnaks. My comments are mostly cosmetic. We can merge this for now and then you can start fleshing things out.
tannewt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! How would you recommend loading the binary? A few comments inline as well.
Is the ports/stm32f4/stm32f4 submodule a mistake?
tannewt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks like a good start to me!
|
@hierophect once this is submitted, please follow up with a PR to get these boards building with GitHub CI so that builds are made available automatically for testing. |
would that just be an empty PR of the same commit? Or do I need to make changes to support GitHub CI? EDIT: looking at Dan recipe - are we still going to merge this PR or should I merge in the CI stuff and then resubmit the PR? |
dhalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's merge this even though the CI is messed up at the moment.
This expands functionality across the STM32F411VE and STM32F412ZG Discovery Boards. Specific features include:
Loading the STM32 binary on the F411VE Discovery can make use of the on-board ST-Link, via tools such as https://github.com/texane/stlink. The F412ZG Discovery is mbed capable and can be loaded over ST-Link much like circuitpython using the programming USB port.