Skip to content

Conversation

@hierophect
Copy link
Collaborator

@hierophect hierophect commented Aug 15, 2019

This expands functionality across the STM32F411VE and STM32F412ZG Discovery Boards. Specific features include:

  • Board, microcontroller and DigitalIO support for the F411
  • USB, internal flash, and FatFS support for the F411
  • I2C support on both discovery boards.
  • Conditionals to support boards without filesystems or low numbers of USB endpoints
  • Minor QOL fixes and additions.

Loading the STM32 binary on the F411VE Discovery can make use of the on-board ST-Link, via tools such as https://github.com/texane/stlink. The F412ZG Discovery is mbed capable and can be loaded over ST-Link much like circuitpython using the programming USB port.

@hierophect
Copy link
Collaborator Author

@tannewt does that last error even have anything to do with my changes? It says it can't install python.

@dhalbert
Copy link
Collaborator

I restarted that subjob. Sometimes the Travis instances are flaky.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnaks. My comments are mostly cosmetic. We can merge this for now and then you can start fleshing things out.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! How would you recommend loading the binary? A few comments inline as well.

Is the ports/stm32f4/stm32f4 submodule a mistake?

tannewt
tannewt previously approved these changes Sep 4, 2019
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks like a good start to me!

@tannewt tannewt requested a review from dhalbert September 4, 2019 18:31
@tannewt
Copy link
Member

tannewt commented Sep 4, 2019

@hierophect once this is submitted, please follow up with a PR to get these boards building with GitHub CI so that builds are made available automatically for testing.

@hierophect
Copy link
Collaborator Author

hierophect commented Sep 4, 2019

@hierophect once this is submitted, please follow up with a PR to get these boards building with GitHub CI so that builds are made available automatically for testing.

would that just be an empty PR of the same commit? Or do I need to make changes to support GitHub CI?

EDIT: looking at Dan recipe - are we still going to merge this PR or should I merge in the CI stuff and then resubmit the PR?

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's merge this even though the CI is messed up at the moment.

@dhalbert dhalbert merged commit b46c8dc into adafruit:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants