Pixelbuf: Add support for 2D pixelbufs #2717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the 0th pixel's value was always returned
This is needed for the Protomatter LED matrix
Member
|
could this be useful for stuff like |
Author
|
@ladyada yeah it sure might be |
Author
|
The "565-format" part would not be relevant, that's purely for protomatter |
Author
|
@ladyada any interest in seeing me pursue this in the near term? If not I'll go ahead and close it up without merging. It's not going to be relevant to protomatter or other framebuffer displays. |
Member
|
i think... its not that necessary since you can make a paletted bitmap and just write to that. can close for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure we necessarily want to take this code, I wrote it while prototyping protomatter, using pixelbuf to hold the framebuffer.
It was useful to be able to index the pixels with (row,column) pairs. However, this is probably not the direction we're going to go with protomatter as we'd like to run it with displayio instead.