New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared-bindings/storage/__init__.c: Change remount() readonly to kw arg (#286). #349

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
@process1183
Collaborator

process1183 commented Oct 19, 2017

The readonly arg to storage.remount() is now a keyword arg that
defaults to False. To maintain backwards compatibility, readonly
can be passed as a positional arg or keyword arg.

I tested my changes with this script. The file was renamed as main.py on the Feather M0 Express. Since the storage could not be remounted while USB was active, the test was run with the Feather plugged into a phone charger. The output from the script is here.

shared-bindings/storage/__init__.c: Change remount() readonly to kw a…
…rg (#286).

The readonly arg to storage.remount() is now a keyword arg that
defaults to False. To maintain backwards compatibility, readonly
can be passed as a positional arg or keyword arg.
@tannewt

You rock! This looks great.

@tannewt tannewt merged commit 3ba5ba6 into adafruit:master Oct 20, 2017

1 of 2 checks passed

rosie-ci/tannewt An error occurred while running the tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@process1183

This comment has been minimized.

Show comment
Hide comment
@process1183

process1183 Oct 20, 2017

Collaborator

@tannewt Thanks! It was a bit of a learning curve, but I had fun working on this.

Collaborator

process1183 commented Oct 20, 2017

@tannewt Thanks! It was a bit of a learning curve, but I had fun working on this.

@process1183 process1183 deleted the process1183:remount branch Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment