esp32s2: esp_error: Consistent error checking of esp-idf calls #3677
Conversation
I wrote this code for audioio but that's not ready for inclusion, and microDEV says it would be useful in their work.
|
Thanks! @jepler. One question, what parameters are you using to categorize an error of type |
|
@microdev1 I think that any error that would plausibly arise from user code we would want to include. I just did the ones in the "main" error header, esp_err.h. |
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thanks for this! Would you mind using a subclass of OSError instead of OSError itself? That way we can differentiate a bit more. There is an example with the espidf.MemoryError already.
| msg = translate("Generic Failure"); | ||
| break; | ||
| case ESP_ERR_NO_MEM: | ||
| msg = translate("Out of memory"); |
There was a problem hiding this comment.
We have a special subclass of MemoryError for this already: https://github.com/adafruit/circuitpython/blob/main/ports/esp32s2/bindings/espidf/__init__.c#L68
|
Are you thinking just one additional class for any esp error? if not, can you let me know what classes you're looking for? |
|
@jepler Ya, one to start with in addition to the existing MemoryError. We can subclass the IDFError exception in the future if need be. |
3 participants
I wrote this code for audioio but that's not ready for inclusion, and @microdev1 says it would be useful in their work.