-Wmissing-prototypes fixes #4607
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include headers where needed * Add/fix declarations / definitions where needed * Mark functions as static if appropriate * Remove some never-used functions This reduces the number of missing-prototypes diagnostics, but is not complete so -Werror=missing-prototypes is not enabled yet.
tannewt
requested changes
Apr 14, 2021
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Please enable the warning in the related build files too. Thanks!
| #include "supervisor/linker.h" | ||
|
|
||
| status_t PLACE_IN_ITCM(flexspi_nor_write_enable)(FLEXSPI_Type * base, uint32_t baseAddr) | ||
| status_t PLACE_IN_ITCM(static flexspi_nor_write_enable)(FLEXSPI_Type * base, uint32_t baseAddr) |
Member
There was a problem hiding this comment.
I think static needs to be first here. Like below. The macro uses the name in the section name too.
Author
|
This was a nice start, but I was unable to find time to finish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function is defined, but its declaration isn't present, the compiler can't check that the declaration and definition match. "-Wmissing-prototypes" enables a diagnostic in this case.
Fixes fall into several categories:
I ran into problems due to this while working on I2SOut for imxrt10xx, and initially thought I could fix them all and enable the diagnostic generally, but that was over-optimistic. This reduces the number of missing-prototypes diagnostics, but is not complete so -Werror=missing-prototypes is not enabled yet.