Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make github-ci install python version "3.x" everywhere we use actions/setup-python (and upgrade to setup-python@v2) #5752

Merged
merged 3 commits into from Dec 21, 2021
Merged

make github-ci install python version "3.x" everywhere we use actions/setup-python (and upgrade to setup-python@v2) #5752

merged 3 commits into from Dec 21, 2021

Conversation

jepler
Copy link
Member

@jepler jepler commented Dec 21, 2021

No description provided.

dunkmann00 and others added 2 commits December 17, 2021 22:41
@dunkmann00 @dhalbert
Explicitly cast float to mp_int_t
0ce5265 
Not sure why this is necessary, but it prevents an off-by-one error in
some (rare?) circumstances.
@jepler
Merge pull request adafruit#5748 from dhalbert/pixelbuf-packed-int-er…
4eb7807 
…ror-7.1.x

Explicitly cast float to mp_int_t - 7.1.x
dhalbert
dhalbert requested changes Dec 21, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's supposed to be "3.x", after looking at actions/setup-python. Also we can upgrade to actions/setup-python@v2. I did that in several libraries already and it was fine.

@dhalbert
Copy link
Collaborator

Sorry for leading us astray earlier with the plain "3". It guess it might work too, but "3.x" seems more typical.

@jepler jepler changed the title make github-ci install python version "3" everywhere we use actions/setup-python make github-ci install python version "3.x" everywhere we use actions/setup-python (and upgrade to setup-python@v2) Dec 21, 2021
@jepler jepler requested a review from dhalbert December 21, 2021 01:23
dhalbert
dhalbert approved these changes Dec 21, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will ignore the cascadetoml failures.

@dhalbert dhalbert merged commit b60a806 into adafruit:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jepler @dhalbert @dunkmann00