-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ESP-IDF 5.0 #8411
Update to ESP-IDF 5.0 #8411
Conversation
Co-authored-by: Casey Webb <caseywebb@protonmail.com>
It boots ljinux just fine. I will throughtly test everything. First thing I found: >>> wifi.radio.connect("Rock4CPlus", "REDACTED")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ConnectionError: No network with that ssid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good luck reviewing the review.
@@ -285,6 +284,7 @@ safe_mode_t port_init(void) { | |||
#endif | |||
|
|||
#if ENABLE_JTAG | |||
ESP_LOGI(TAG, "Marking JTAG pins never_reset") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waste of binary space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only included in debug
builds.
ports/espressif/boards/espressif_esp32s2_devkitc_1_n4r2/mpconfigboard.mk
Show resolved
Hide resolved
ports/espressif/boards/espressif_esp32s3_devkitc_1_n8r2/mpconfigboard.mk
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
I turned off |
This is an irrelevant issue I just found that also is in current main. |
Yup, we'll need to test a lot once it is all merged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this big endeavor and thanks to @microdev1 also!
The sdkconfig
refactoring is really great -- really makes things simpler.
I will add an issue to re-enable rgbmatrix
unless you are already working on this.
I haven't started yet. Will need to coordinate with @PaintYourDragon I think for the IDF update. |
Based on #6913 by @microdev1. Thank you so much!