Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ESP-IDF 5.0 #8411

Merged
merged 29 commits into from
Sep 22, 2023
Merged

Update to ESP-IDF 5.0 #8411

merged 29 commits into from
Sep 22, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 18, 2023

Based on #6913 by @microdev1. Thank you so much!

@tannewt tannewt added the espressif applies to multiple Espressif chips label Sep 18, 2023
@tannewt tannewt added this to the 9.0.0 milestone Sep 18, 2023
@bill88t
Copy link

bill88t commented Sep 18, 2023

It boots ljinux just fine.
So pretty much the whole core works.

I will throughtly test everything.

First thing I found:

>>> wifi.radio.connect("Rock4CPlus", "REDACTED")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ConnectionError: No network with that ssid

Copy link

@bill88t bill88t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck reviewing the review.

supervisor/shared/web_workflow/web_workflow.c Show resolved Hide resolved
@@ -285,6 +284,7 @@ safe_mode_t port_init(void) {
#endif

#if ENABLE_JTAG
ESP_LOGI(TAG, "Marking JTAG pins never_reset")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waste of binary space?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only included in debug builds.

ports/espressif/peripherals/i2c.c Outdated Show resolved Hide resolved
ports/espressif/boards/deneyap_kart_1a_v2/mpconfigboard.mk Outdated Show resolved Hide resolved
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@microdev1
Copy link
Collaborator

I turned off rgbmatrix in ba22633, the submodule needs to be updated. Can be done as a seperate issue?

@bill88t
Copy link

bill88t commented Sep 21, 2023

It boots ljinux just fine. So pretty much the whole core works.

I will throughtly test everything.

First thing I found:

>>> wifi.radio.connect("Rock4CPlus", "REDACTED")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ConnectionError: No network with that ssid

This is an irrelevant issue I just found that also is in current main.

@tannewt
Copy link
Member Author

tannewt commented Sep 21, 2023

I turned off rgbmatrix in ba22633, the submodule needs to be updated. Can be done as a seperate issue?

Yup, we'll need to test a lot once it is all merged in.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this big endeavor and thanks to @microdev1 also!

The sdkconfig refactoring is really great -- really makes things simpler.

I will add an issue to re-enable rgbmatrix unless you are already working on this.

@tannewt
Copy link
Member Author

tannewt commented Sep 22, 2023

I will add an issue to re-enable rgbmatrix unless you are already working on this.

I haven't started yet. Will need to coordinate with @PaintYourDragon I think for the IDF update.

@tannewt tannewt merged commit d6b284e into adafruit:main Sep 22, 2023
152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
espressif applies to multiple Espressif chips
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants