Allow overriding EXTRA_BUILTIN_MODULES in mpconfigboard.h#854
Merged
Conversation
tannewt
reviewed
May 21, 2018
Member
There was a problem hiding this comment.
Why is this undef needed? My guess is there is somewhere we're including mpconfigboard.h directly when we should use py/mpconfig.h instead
Author
There was a problem hiding this comment.
Oops, it's not needed, It's left over from my previous attempt at this. I will remove it.
Some boards (like the uGame10) may want to have their own set of extra modules. This change lets them override EXTRA_BUILTIN_MODULES in their mpconfigboard.h and makes the ugame10 board do that.
tannewt
approved these changes
May 22, 2018
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks good! I'm very excited for more gaming support in CircuitPython.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some boards (like the uGame10) may want to have their own set of extra
modules. This change lets them override EXTRA_BUILTIN_MODULES in their
mpconfigboard.h and makes the ugame10 board do that.