M5 stamp s3 cardputer build#8810
Closed
jamesjnadeau wants to merge 6 commits into
Closed
Conversation
Author
|
not sure what was up with the .pot file change... I can remake without that... |
tannewt
requested changes
Jan 18, 2024
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Yes, please remove the .pot file too. It will be autoupdated separately. Thanks for the new board def!
Comment on lines
+2
to
+4
| USB_PID = 0x811A | ||
| USB_PRODUCT = "M5STACK CoreS3 - CircuitPython" | ||
| USB_MANUFACTURER = "M5STACK" |
Member
There was a problem hiding this comment.
These look like the values for a different board. Please update.
Author
|
I'm going to close this and resubmit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my working build of circuit python for the M5 stack cardputer.
I have updated the USB parameters per https://github.com/espressif/usb-pids
Thanks for your time and for making this pretty easy to get going, your docs are fabulous!