Skip to content

Remove deprecated ::set-env #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jepler merged 2 commits into from
Dec 10, 2020
Merged

Remove deprecated ::set-env #94

jepler merged 2 commits into from
Dec 10, 2020

Conversation

@jepler
Copy link
Contributor

@jepler jepler commented Dec 10, 2020

This should fix the CI error seen in #93

@jepler
Remove deprecated ::set-env
33d5a2d
@jepler
try upgrading pip
1b8256a 
This is an attempt to address pip's failure to install the expected version of
chardet during "Test cookiecutter Generation (on: pull_request)".
Confusingly, this does not affect "Test cookiecutter Generation (on: push)".
@jepler
Copy link
Contributor Author

jepler commented Dec 10, 2020

I also encountered a CI problem which said

We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.

requests 2.25.0 requires chardet<4,>=3.0.2, but you'll have chardet 4.0.0 which is incompatible.
WARNING: You are using pip version 20.2.4; however, version 20.3.1 is available.
You should consider upgrading via the '/opt/hostedtoolcache/Python/3.6.12/x64/bin/python -m pip install --upgrade pip' command

Upgrading pip explicitly during the test process seems to have resolved the problem. It's not clear to me why the older version of pip installed the wrong chardet, but newer is better right?

@jepler jepler requested a review from a team December 10, 2020 22:21
@jepler jepler merged commit ce3b9f8 into master Dec 10, 2020
@askpatrickw askpatrickw deleted the safely-set-env branch September 14, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ladyada ladyada ladyada approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jepler @ladyada