Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Bug fix for glcdWriteCharGr

  • Loading branch information...
commit f983c755af657b5097ddf4a80c92731115f3f3c5 1 parent 705d8c4
CaitSith2 CaitSith2 authored

Showing 1 changed file with 4 additions and 1 deletion. Show diff stats Hide diff stats

  1. +4 1 firmware/glcd.c
5 firmware/glcd.c
@@ -304,7 +304,10 @@ void glcdWriteCharGr(u08 grCharIdx)
304 304 {
305 305 // add this graphic's length to the startIdx
306 306 // to get the startIdx of the next one
307   - grStartIdx += pgm_read_byte(FontGr+grStartIdx);
  307 + // 2010-03-03 BUG Dataman/CRJONES There's a bug here: Have to add 1 for the byte-cout.
  308 + // grStartIdx += pgm_read_byte(FontGr+grStartIdx);
  309 + grStartIdx += pgm_read_byte(FontGr+grStartIdx)+1;
  310 +
308 311 }
309 312 grLength = pgm_read_byte(FontGr+grStartIdx);
310 313

1 comment on commit f983c75

Dataman

Caitsith: Are you sure about this one? Looks like you just backed out my patch of 2010-03-03. The way the table is set up in memory, the byte count is the first byte. I guess it depends on how you configure the data table, but this should really break IntruderChron.

Please sign in to comment.
Something went wrong with that request. Please try again.