more rt10xx fix #230
Merged
more rt10xx fix #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add uart for logging
hathach
commented
Jul 15, 2022
| @@ -58,8 +61,11 @@ static void write_tinyuf2_to_flash(void) | |||
| uint8_t const* image_data = (uint8_t const *) &qspiflash_config; | |||
| uint32_t flash_addr = FCFB_START_ADDRESS; | |||
|
|
|||
| // fcfb + bootloader (ivt, interrupt, text) | |||
| uint32_t const end_addr = FLEXSPI_FLASH_BASE + ((uint32_t) _fcfb_length) + BOARD_BOOT_LENGTH; | |||
There was a problem hiding this comment.
@ehughes following up to your PR, I think this also need changes as well. Let me know if this makes sense to you.
There was a problem hiding this comment.
I will merge this as it is for now, should it has any issues, we could fix it in following PR. thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #220
Note: RT1020EVK working great, but RT1024 has trouble with load code from internal qspi flash, probably misconfigured flash parameters or something. will create an separate issue to remind this.
Update: issue #231