Skip UTF BOM from first data event on UTF-8 decoded stream #55

Merged
merged 1 commit into from Oct 18, 2012

Conversation

Projects
None yet
2 participants
@dougwilson
Contributor

dougwilson commented Oct 18, 2012

This is a conservative implementation for issue #36. I don't always agree with things stripping the UTF BOM on a file, but it seems it may be useful for the CSV parser. This will strip the BOM from a stream only when the stream's encoding is set to UTF-8 and the BOM is the first character in the first data event (which should be the beginning of the file 99% of the time).

wdavidw pushed a commit that referenced this pull request Oct 18, 2012

Worms David
Merge pull request #55 from dougwilson/feature/skip-utf8-bom
Skip UTF BOM from first data event on UTF-8 decoded stream

@wdavidw wdavidw merged commit 40dfd12 into adaltas:master Oct 18, 2012

1 check passed

default The Travis build passed
Details
@wdavidw

This comment has been minimized.

Show comment
Hide comment
@wdavidw

wdavidw Oct 18, 2012

Collaborator

This is how I was planning to do it. Look perfect to me.

Collaborator

wdavidw commented Oct 18, 2012

This is how I was planning to do it. Look perfect to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment