Skip to content

GFM tables not supported #13

Closed
adam-p opened this Issue Jun 7, 2012 · 4 comments

2 participants

@adam-p
Owner
adam-p commented Jun 7, 2012

Due to a bug in our Markdown renderer -- chjj/marked#50 -- we do not have support for GFM-style tables.

For example, this...

First Header | Second Header
------------ | -------------
Content Cell | Content Cell
Content Cell | Content Cell

...renders to this in Github...

First Header Second Header
Content Cell Content Cell
Content Cell Content Cell

...but not in Markdown here.

(This issue is forked from adam-p/markdown-here#9.)

@caseywatts

It looks like this is fixed now

@adam-p
Owner
adam-p commented Jan 31, 2013

It is, and I've incorporated the new Marked features into the codebase -- it'll be in the next release.

If you want to play with it, you can grab the development branch. If you want a sneak peak of the upcoming changes, check out the CHANGES file in that branch.

(Academically speaking... I'm not sure what to do about bugs that are fixed in a task branch but not yet released. Close them anyway? Set a milestone? Add a comment about the upcoming fix? I guess I should do that, at least.)

@caseywatts

Woo, I'm so excited! :D

That's a great point, I've never put time to that :o
My projects have always closed issues when the fix is finally pushed to the development branch, but we don't have huge followings that might actually read these. If there's a convention on github, I'm not aware of it.

@adam-p
Owner
adam-p commented Feb 6, 2013

Added in Markdown Here v2.7.0. Enjoy.

@adam-p adam-p closed this Feb 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.