Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Button #34

Closed
jakov opened this issue Oct 23, 2012 · 4 comments
Closed

Provide a Button #34

jakov opened this issue Oct 23, 2012 · 4 comments
Labels

Comments

@jakov
Copy link

@jakov jakov commented Oct 23, 2012

Using the shortcut for toggling is good, but some (including me) might prefer to have a button for toggling.

The button should ideally be greyed out when no text-field is selected.

@adam-p
Copy link
Owner

@adam-p adam-p commented Oct 29, 2012

You're absolutely right. I dislike extra buttons being added to my browser, and the context menu item and shortcut key are good enough for me, but... I can certainly understand that other people would like a button. I should have added one long ago.

I'll try to get this implemented soon-ish.

@jakov
Copy link
Author

@jakov jakov commented Oct 29, 2012

Some might dislike extra context menus or shortcuts ;)

There are a lot of addons that provide optional buttons, e.g. one for almost every menu item. This way it would be very unobstrusive.

Another (more difficult) option would be to place a button/link next to every textfield on the page (maybe combined with whitelist and blacklist for where it should not appear).

Am 29.10.2012 um 04:12 schrieb Adam Pritchard notifications@github.com:

You're absolutely right. I dislike extra buttons being added to my browser, and the context menu item and shortcut key are good enough for me, but... I can certainly understand that other people would like a button. I should have added one long ago.

I'll try to get this implemented soon-ish.


Reply to this email directly or view it on GitHub.

@adam-p
Copy link
Owner

@adam-p adam-p commented Oct 29, 2012

There are a lot of addons that provide optional buttons, e.g. one for almost every menu item. This way it would be very unobstrusive.

Yes. And the browsers themselves also make it pretty easy to manage which buttons are showing in the chrome. I might just leverage that rather than creating a new option.

Another (more difficult) option would be to place a button/link next to every textfield on the page (maybe combined with whitelist and blacklist for where it should not appear).

I really don't want to do that. If I start modifying web pages, it'll introduce a whole new level of code complexity (and testing, and support...). Plus, it's pretty difficult to know where Markdown Here will work and not work (and to what degree) without trying. So... yeah, probably not going to put buttons in the page.

@adam-p
Copy link
Owner

@adam-p adam-p commented Feb 6, 2013

Toolbar button added in v2.7.0, released today. I'll think about adding an inline button in the future, but I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.