New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions hierarchy #19

Merged
merged 11 commits into from May 30, 2013

Conversation

Projects
None yet
2 participants
@davidroberts63

davidroberts63 commented May 27, 2013

Here is what I have. A few points to go over:

  • I took the liberty of changing the name of some of the tests that I touched to express what is being tested within which class. If you would rather keep the original test names just let me know. I have no problem going back to them. Having looked at more tests they seem more BDD oriented instead of unit test/TDD oriented so I may have overstepped on the naming.
  • I was considering splitting out the exceptions into a file for each exception class but wanted to check with you first. Either way is fine by me, your call.

David Roberts added some commits May 25, 2013

David Roberts
Invalid Operation when entry assembly not known
The use of ArgException when the entry assembly is not known
during use was less than ideal. An InvalidOperationException points out
the true problem.
David Roberts
Throw UnexpectedArgumentException instead of ArgException
A finer grained exception for clients to process individually. Also renamed
the test to provide a little bit more info on what is being tested.
David Roberts
Throw DuplicateArgException instead of ArgException
A finer grained exception for clients to process individually. Also renamed
the test to provide a little bit more info on what is being tested.
David Roberts
Throw MissingArgException instead of ArgException
A finer grained exception for clients to process individually. Also renamed
the test to provide a little bit more info on what is being tested.
David Roberts
Throw UnknownActionArgException instead of ArgException
A finer grained exception for clients to process individually.
David Roberts
Throw MissingArgException instead of ArgException
A finer grained exception for clients to process individually.
David Roberts
Throw ValidationArgException in the ArgValidators
Some tests were testing two things, exception and
correct values for validators. I split those out to their
individual tests.
@davidroberts63

This comment has been minimized.

Show comment
Hide comment
@davidroberts63

davidroberts63 May 27, 2013

Forgo to reference the issue:

#11

davidroberts63 commented May 27, 2013

Forgo to reference the issue:

#11

@adamabdelhamed

This comment has been minimized.

Show comment
Hide comment
@adamabdelhamed

adamabdelhamed May 28, 2013

Owner

Single file for the exceptions is fine. After a first pass it looks good. I haven't pulled it down and played with it yet. As soon as I do that I'll either get back to you with a question or two or I'll just merge it in.

Thanks for the good work!
Adam

Owner

adamabdelhamed commented May 28, 2013

Single file for the exceptions is fine. After a first pass it looks good. I haven't pulled it down and played with it yet. As soon as I do that I'll either get back to you with a question or two or I'll just merge it in.

Thanks for the good work!
Adam

adamabdelhamed pushed a commit that referenced this pull request May 30, 2013

@adamabdelhamed adamabdelhamed merged commit e7f3f16 into adamabdelhamed:master May 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment