New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perl 6] Feedback from a a person new to Perl 6 #1390
Comments
|
I have a hard time believing you're new to it... But thanks ;-). |
|
@vendethiel Me too ! =D |
|
@vendethiel @Ribeiro lol, I wonder what it is about me that makes that suspicious? :) I've been meaning to learn Perl 6 for a while, but never had the time. Learning now though. As for the PR: I actually found more stuff (I'm midway through the tutorial right now). I'll keep adding what I find to the list above and when I'm done with the tutorial I'll make a PR for anything that I can fix :) |
|
I've seen you on IRC pretty often |
|
@zoffixznet Please, keep up the good work since Perl seems like hieroglyphs to me =D |
|
I'm finished. The few items that I werent able to answer in my PR (#1434) are the non-crossed out items at the top :) |
|
You're first item, a comment about a possible misfeature is because many peope believe that multiple inheritance is a bad thing, and that simply having it in the langauge is a bad thing. There is of course nothing wrong with perl6's implementation of inheritance, nor in it's implementation of multiple inheritance. |
|
Thanks! I've updated the PR (removed the |
This was added at some point:
Those were removed at a previous time
That was reworded at some point, but I changed it again.
I added a (hopefully better) explanation. @zoffixznet If you agree those are fixed, we can close this :-). |
|
Thanks! |
Hey,
Just some of my feedback for what I found confusing on the tutorial; I'm totally new to Perl 6:
Content and Terms
my @array = 1..20;before them.packagedoes, so mentioning at all is confusing.using packages directly. Should it be wordedusing "package" keyword directly?assert pre/post- conditionis. Maybe add an example? Or remove some phasers from the tutThis makes me feel the implementation is broken or that I shouldn't be using inheritance. The line should either be removed or it should be briefly explained what exactly is the issue with inheritance.Hereabc=>ABCfor extra clarityOutput here should beaeThis actually dies now withUnable to deduce arithmetic or geometric sequencesplat?? No idea what that is.I think it's@or*@. Check and add explanation.It's the*(from Ruby's term for an operator like that). Need to clarify in the docsI'd suggest removingENTERfrom this line here, sinceENTERphaser there is superfluous and the example confuses about the purpose of theENTERphaser; makes you question what difference it provides there as opposed to plain$db.start-transaction;This, this, this, this, this (and one below it) lines are too long and get cut offIsexecutedthe right term to use here? Wouldinitializedbe clearer?This entire paragraph should be rewritten. It starts withour..., then mentionsmyeven though it was just mentioned a few lines prior, then it mentions someprevious part, which made me gohuh? wat?This does not seem to be the case any longer. I getSemicolon form of 'module' without 'unit' is illegal. You probably want to use 'unit module'I've no idea what theautoquoted => "key"bit does. How does the auto-quotation mechanism work?I've just now realized thatautoquotedis a name of a key and not a processing instruction. What confused me is that when I dumped the hash withsay %hash.perl;, I got{:autoquoted("key"), "some other" => "value"}, which made me think:autoquotedwas something special. The keyautoquotedshould be renamed to something more generic and easily recognizable; e.gfoo => "bar"Here, that line should probably be moved all the way to here. In its current place it doesn't make much sense. Also, here, I'd changecapturetostore in a variable.Here it's unclear whatAnyis. It's explained a few lines below, here, and I think some confusion can be avoided by moving explanation to earlier in the text.This bit is really confusing. I logged in to IRC to ask the channel, and then recalled Larry's talk about "magic" in list generation. It's not obvious how the values are generated in that sequence. It should be explained in the comments or use more obvious pattern, likemy @seq = 0, 5, 10 ...^ * > 100;Here there seems to besome confusion in the comments with
$*avs.$*fooHere the sentences about$.and$!seem broken and are confusing.This entire section seems to use term "fields" for class's attribute. Perl 6 devs call them attributes and so do some other languages. It would be nice to have consistency in nomenclature.Typos
Hereparamater=>parameterHerewant is a copy=>want a copyHerelanguages=>languages'Hereexaminate=>examineHere Opening(is not neededHeretry=>triedheredenomitor=>denominatorHerethose that can have=>those that can, haveRemove wordinsteadhereHere:trick=>tricksHerenot=>noHerereturn=>returnsHerefunctions=>functionHereruns the an array with all these=>returns an array with all of theseHereargument=>argumentsHereperl 6=>perl6The text was updated successfully, but these errors were encountered: