[rust/de] [rust/en] [rust/es] [rust/fr] [rust/cn] Fix comment in Rust docs: box -> mine #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rob--W
commented
Sep 11, 2016
Rob--W
commented
- PR touches only one file (or a set of logically related files with similar changes made)
- Content changes are aimed at intermediate to experienced programmers (this is a poor format for explaining fundamental programming concepts)
- YAML Frontmatter formatted according to CONTRIBUTING.md
- Seriously, look at it now. Watch for quotes and double-check field names.
The "box" is referring to the Box variable a few lines back, but that is called "mine", not "box".
| @@ -285,7 +285,7 @@ fn main() { | |||
| var = 3; | |||
| let ref_var: &i32 = &var; | |||
|
|
|||
| println!("{}", var); // Contrairement `box`, `var` peut encore être utilisé | |||
| println!("{}", var); // Contrairement `mien`, `var` peut encore être utilisé | |||
There was a problem hiding this comment.
That is not a typo, that is the name of the variable at line 267.
There was a problem hiding this comment.
ugh. i really did a bad job of proofreading that one :-(.
|
Thanks. |
23Pstars
pushed a commit
to 23Pstars/learnxinyminutes-docs
that referenced
this pull request
Feb 11, 2017
The "box" is referring to the Box variable a few lines back, but that is called "mine", not "box".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.